SpotBugs Bug Detector Report
The following document contains the results of SpotBugs
SpotBugs Version is 4.3.0
Threshold is medium
Effort is default
Summary
Classes |
Bugs |
Errors |
Missing Classes |
96 |
19 |
0 |
0 |
org.eclipse.jgit.internal.transport.sshd.JGitClientSession
Bug |
Category |
Details |
Line |
Priority |
org.eclipse.jgit.internal.transport.sshd.JGitClientSession.getCredentialsProvider() may expose internal representation by returning JGitClientSession.credentialsProvider |
MALICIOUS_CODE |
EI_EXPOSE_REP |
134 |
Medium |
org.eclipse.jgit.internal.transport.sshd.JGitClientSession.getHostConfigEntry() may expose internal representation by returning JGitClientSession.hostConfig |
MALICIOUS_CODE |
EI_EXPOSE_REP |
105 |
Medium |
org.eclipse.jgit.internal.transport.sshd.JGitClientSession.setCredentialsProvider(CredentialsProvider) may expose internal representation by storing an externally mutable object into JGitClientSession.credentialsProvider |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
125 |
Medium |
org.eclipse.jgit.internal.transport.sshd.JGitClientSession.setHostConfigEntry(HostConfigEntry) may expose internal representation by storing an externally mutable object into JGitClientSession.hostConfig |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
115 |
Medium |
org.eclipse.jgit.internal.transport.sshd.JGitHostConfigEntry
Bug |
Category |
Details |
Line |
Priority |
org.eclipse.jgit.internal.transport.sshd.JGitHostConfigEntry.setMultiValuedOptions(Map) may expose internal representation by storing an externally mutable object into JGitHostConfigEntry.multiValuedOptions |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
35 |
Medium |
org.eclipse.jgit.internal.transport.sshd.JGitSshClient
Bug |
Category |
Details |
Line |
Priority |
org.eclipse.jgit.internal.transport.sshd.JGitSshClient.getCredentialsProvider() may expose internal representation by returning JGitSshClient.credentialsProvider |
MALICIOUS_CODE |
EI_EXPOSE_REP |
377 |
Medium |
org.eclipse.jgit.internal.transport.sshd.JGitSshClient.setCredentialsProvider(CredentialsProvider) may expose internal representation by storing an externally mutable object into JGitSshClient.credentialsProvider |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
368 |
Medium |
org.eclipse.jgit.internal.transport.sshd.JGitUserInteraction
Bug |
Category |
Details |
Line |
Priority |
new org.eclipse.jgit.internal.transport.sshd.JGitUserInteraction(CredentialsProvider) may expose internal representation by storing an externally mutable object into JGitUserInteraction.provider |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
49 |
Medium |
org.eclipse.jgit.internal.transport.sshd.OpenSshServerKeyDatabase
Bug |
Category |
Details |
Line |
Priority |
Random object created and used only once in org.eclipse.jgit.internal.transport.sshd.OpenSshServerKeyDatabase.createHostKeyLine(Collection, PublicKey, ServerKeyDatabase$Configuration) |
BAD_PRACTICE |
DMI_RANDOM_USED_ONLY_ONCE |
694 |
High |
Redundant nullcheck of newEntry, which is known to be non-null in org.eclipse.jgit.internal.transport.sshd.OpenSshServerKeyDatabase.updateKnownHostsFile(Collection, PublicKey, Path, ServerKeyDatabase$Configuration) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
331 |
Medium |
org.eclipse.jgit.internal.transport.sshd.agent.ConnectorFactoryProvider
Bug |
Category |
Details |
Line |
Priority |
Public static org.eclipse.jgit.internal.transport.sshd.agent.ConnectorFactoryProvider.getDefaultFactory() may expose internal representation by returning ConnectorFactoryProvider.INSTANCE |
MALICIOUS_CODE |
MS_EXPOSE_REP |
44 |
Medium |
org.eclipse.jgit.internal.transport.sshd.agent.JGitSshAgentFactory
Bug |
Category |
Details |
Line |
Priority |
new org.eclipse.jgit.internal.transport.sshd.agent.JGitSshAgentFactory(ConnectorFactory, File) may expose internal representation by storing an externally mutable object into JGitSshAgentFactory.factory |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
49 |
Medium |
org.eclipse.jgit.internal.transport.sshd.auth.AbstractAuthenticationHandler
Bug |
Category |
Details |
Line |
Priority |
new org.eclipse.jgit.internal.transport.sshd.auth.AbstractAuthenticationHandler(InetSocketAddress) may expose internal representation by storing an externally mutable object into AbstractAuthenticationHandler.proxy |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
43 |
Medium |
org.eclipse.jgit.internal.transport.sshd.proxy.AbstractClientProxyConnector
Bug |
Category |
Details |
Line |
Priority |
new org.eclipse.jgit.internal.transport.sshd.proxy.AbstractClientProxyConnector(InetSocketAddress, InetSocketAddress, String, char[]) may expose internal representation by storing an externally mutable object into AbstractClientProxyConnector.proxyAddress |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
73 |
Medium |
new org.eclipse.jgit.internal.transport.sshd.proxy.AbstractClientProxyConnector(InetSocketAddress, InetSocketAddress, String, char[]) may expose internal representation by storing an externally mutable object into AbstractClientProxyConnector.remoteAddress |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
74 |
Medium |
org.eclipse.jgit.transport.sshd.IdentityPasswordProvider
Bug |
Category |
Details |
Line |
Priority |
new org.eclipse.jgit.transport.sshd.IdentityPasswordProvider(CredentialsProvider) may expose internal representation by storing an externally mutable object into IdentityPasswordProvider.provider |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
115 |
Medium |
org.eclipse.jgit.transport.sshd.IdentityPasswordProvider$State
Bug |
Category |
Details |
Line |
Priority |
org.eclipse.jgit.transport.sshd.IdentityPasswordProvider$State.getPassword() may expose internal representation by returning IdentityPasswordProvider$State.password |
MALICIOUS_CODE |
EI_EXPOSE_REP |
98 |
Medium |
org.eclipse.jgit.transport.sshd.ProxyData
Bug |
Category |
Details |
Line |
Priority |
org.eclipse.jgit.transport.sshd.ProxyData.getProxy() may expose internal representation by returning ProxyData.proxy |
MALICIOUS_CODE |
EI_EXPOSE_REP |
73 |
Medium |
new org.eclipse.jgit.transport.sshd.ProxyData(Proxy, String, char[]) may expose internal representation by storing an externally mutable object into ProxyData.proxy |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
55 |
Medium |