------------------------------------------------------------------------ r2299 | Darkvater | 2005-05-12 00:20:16 +0000 (Thu, 12 May 2005) | 2 lines - Fix: add more verbose output to possible hack-attempt. - Btw, only 14 more commands are remaining, 88% done \o/ ------------------------------------------------------------------------ r2298 | Darkvater | 2005-05-12 00:18:30 +0000 (Thu, 12 May 2005) | 4 lines - CodeChange: removed CmdAbuses: CmdSetTownNameType(), CmdStartNewGame(), CmdCreateScenario(), CmdSetNewLandscapeType() and CmdGenRandomNewGame(). - CodeChange: renamed CmdTrainGotoDepot() to CmdSendTrainToDepot() to be consistent with other depot commands. - CodeChange: 'newgame' console command now calls the unabused GenRandomNewGame(). For the server it still creates a new game, a client quits the game and continues in SP. - CodeChange: in the game-difficulty window, setup the disabled buttons on window creation, not every redraw. ------------------------------------------------------------------------ r2297 | Darkvater | 2005-05-12 00:11:37 +0000 (Thu, 12 May 2005) | 4 lines - CodeChange: server-check the next batch of commands. - CodeChange: since only the server will be able to modify difficulty settings, leave the checking of correct values besides, and trust users will join legit servers. - CodeChange: for renaming signs, only check if GetDParam(); eg _decode_parameters is empty ('\0') or not, instead of the extra check of players, etc. That basically does the same thing. Also dirty sign two times when renaming, once before, once after the action. Because if the name becomes shorter and you update only after, garbage remains on the screen. - CodeChange: made GetMaskOfTownActions() available to the town-cmd to double-check if the action was available to the player. For this purpose the hardcoded _local_player has been removed from the function and is now passed as a parameter. ------------------------------------------------------------------------ r2296 | darkvater | 2005-05-11 18:09:12 +0000 (Wed, 11 May 2005) | 1 line - Fix (regression): oops, forgot the MS code-decleration rules :p ------------------------------------------------------------------------ r2295 | Darkvater | 2005-05-11 16:29:33 +0000 (Wed, 11 May 2005) | 1 line - Fix: you were still able to delete any tile if you were not careful with CmdDestroyCompanyHQ. Fixed this; thanks HackyKid. ------------------------------------------------------------------------ r2294 | Darkvater | 2005-05-11 16:17:03 +0000 (Wed, 11 May 2005) | 1 line - CodeChange: check the service interval settings when changing of all vehicle-types. To simplify things introduce GetServiceIntervalClamped() that returns the same or clamped value of the new service interval. There were some inconsistencies in the gui files so I had to change those, and const correctness kicked in, so it's a bit messy at certain points. ------------------------------------------------------------------------ r2293 | Darkvater | 2005-05-11 15:31:10 +0000 (Wed, 11 May 2005) | 1 line - Fix (regression): You couldn't modify commands anymore; fixed. (|| and && are kinda confusing with !=) :P ------------------------------------------------------------------------ r2292 | Darkvater | 2005-05-11 15:30:28 +0000 (Wed, 11 May 2005) | 1 line - Fix (regression): make error message more general for console errors. Dedicated servers are properly filtered out when requesting player-password. ------------------------------------------------------------------------ r2291 | Darkvater | 2005-05-11 12:46:19 +0000 (Wed, 11 May 2005) | 1 line - Fix (regression): When a client joined it changed the server-player's name. Funny effect; but not desired. Thanks for pointing it out Tron. It needed a bit of hacking, but is not less of a hack than the one used before :) ------------------------------------------------------------------------ r2290 | Darkvater | 2005-05-11 00:00:27 +0000 (Wed, 11 May 2005) | 6 lines - CodeChange: protect the next batch of commands. This brings us to a total of 61, which is 53% :) - CodeChange: To correctly accept engine-prototypes, the best-player checking has been moved to its own function, I hope it functions the same as before. - CodeChange: Added symbolic types of PlayerID, OrderID and EngineID. For engines also added GetEngine() and IsEngineIndex(), similar to the other such functions. - CodeChange: To correctly build industries, some tables have been moved to build_industry.h. The only way to find out currently if an industry is valid in a climate is by looping all industries and checking if it matches. Also to comply with the patch setting build_rawmaterial_industries, it is assumed that these industries do not accept any cargo of any type. This can and probably should changed in the future to some flag in their struct. Also use _opt_ptr instead of _opt. - CodeChange: implemented the HQ checking code inspired by MarkR2 in "[ 1190944 ] Many commands not checked for security". Unfortunately it is impossible to prevent only deleting a HQ by a modified client atm. - CodeChange: For insert order and modify order their parameters are implicitely truncated to 8 bits, instead of the 16 bits said in the comments. ------------------------------------------------------------------------ r2289 | Darkvater | 2005-05-10 08:45:55 +0000 (Tue, 10 May 2005) | 2 lines - Fix (regression): check p1 param of road-depot building instead of unused p2 (typo). Thanks peter1138. ------------------------------------------------------------------------ r2288 | Darkvater | 2005-05-09 22:33:00 +0000 (Mon, 09 May 2005) | 5 lines - CodeChange: protected the next batch of commands (41 so far, out of 115). - CodeChange: changed the airport gui airport-type checking. Added function GetValidAirports() that returns bitmasked availibility, is also used for checking. - CodeChange: to check tree-planting, 2 const arrays have been moved to table/tree_land.h (type and count) - CodeChange: added IsTownIndex() in following of IsStationIndex(), etc. - Fix (regression): road tunnels did not work anymore, forgot that their type was 0x200 (documented now) ------------------------------------------------------------------------ r2287 | Darkvater | 2005-05-09 19:56:08 +0000 (Mon, 09 May 2005) | 1 line - Fix (regression): cast stationcount to unsigned instead of p1 to signed when checking valid waypoint types. Thanks for pointing it out Tron ------------------------------------------------------------------------ r2286 | Darkvater | 2005-05-09 16:37:40 +0000 (Mon, 09 May 2005) | 2 lines - CodeChange: paramcheck the next batch of commands. - Fix (regression): fix up terraform land where every player can terraform land (towns, map generation), and player can terraform different corners; used for building tunnels ------------------------------------------------------------------------ r2285 | Darkvater | 2005-05-09 13:26:15 +0000 (Mon, 09 May 2005) | 2 lines - Codechange: Fix up some of the missing things from server-checking; namely bridge-type, bridge-length, dragged end-tile (bridge/station), station_spread - Fix: [ 1197256 ] max station spread patch < 7 does not work. Station spread was not taking into account when not using drag&drop. Fix this up, and add a callback to the settings window to immediately reflect the changes. ------------------------------------------------------------------------ r2284 | Darkvater | 2005-05-08 21:00:56 +0000 (Sun, 08 May 2005) | 1 line - Fix (regression): [ 1197177 ] Scenario editor: desert add/remove tool removes industries. Fixed a bit too agressive desert generator. It still does remove the industry (sand's a bitch on machinery), but at least it does it cleanly :) ------------------------------------------------------------------------ r2283 | Darkvater | 2005-05-08 20:53:02 +0000 (Sun, 08 May 2005) | 1 line - Fix (regression): [ 1197493 ] train_gui.c:1341: failed assertion ..., somehow RebuildVehicleList() got lost during the rewrite :P ------------------------------------------------------------------------ r2282 | miham | 2005-05-08 16:17:01 +0000 (Sun, 08 May 2005) | 1 line [Translations] Updated to 2005-05-08 (58 strs / 3 langs) ------------------------------------------------------------------------ r2281 | matthijs | 2005-05-07 22:00:36 +0000 (Sat, 07 May 2005) | 8 lines - Fix: [ 1115204 ] [NPF] When pressing the goto depot button, trains will now also look behind it if there is no depot in front. If so, the train reverses immediately. This also work anywhere, not just at stations. - Add: [NPF] Reversing inside of depots now has a penalty. It also applies to trains only, other vehicles shouldn't bother reversing. - Fix: [NPF] When checking whether to reverse a train, the trackdir of the first loc was used instead of the last vehicle as a starting node for pathfindig. This might have caused some trains not reversing when they should have (or vice versa). Typo introduced when converting to GetVehicleTrackdir() in r2256. - CodeChange: [NPF] Removed duplicate code by letting NPFRouteTjoStationOrTile() call NPFRouteToStationOrTileTwoWay(). - Add: [NPF] NPFRouteToDepotBreadthFirstTwoWay() to find a depot while also looking backwards. - Add: It is now possibly to specify a path cost for aystar starting nodes. ------------------------------------------------------------------------ r2280 | Darkvater | 2005-05-07 10:26:45 +0000 (Sat, 07 May 2005) | 1 line - Fix: Check if the passed tile to DoCommand is within the current mapsize ------------------------------------------------------------------------ r2279 | Darkvater | 2005-05-07 10:26:12 +0000 (Sat, 07 May 2005) | 1 line - Fix: Check the parameters of the first 10 Commands. While there also add proper comments for the functions and fix up CmdFailed() ------------------------------------------------------------------------ r2278 | tron | 2005-05-07 08:14:06 +0000 (Sat, 07 May 2005) | 1 line When renaming a station, check if the station exists and belongs to the correct player ------------------------------------------------------------------------ r2277 | Darkvater | 2005-05-06 22:06:40 +0000 (Fri, 06 May 2005) | 1 line - Codechange: change sscanf() into stroul() Which Does The Right Thing tm. Thanks tron ------------------------------------------------------------------------ r2276 | Darkvater | 2005-05-06 20:38:18 +0000 (Fri, 06 May 2005) | 1 line - CodeChange: remove DebugProc() and make the ALT+0...4 codes only available in debug mode ------------------------------------------------------------------------ r2275 | Darkvater | 2005-05-06 18:34:28 +0000 (Fri, 06 May 2005) | 1 line - Fix: [ 1196662 ] scrollto doesn't accept hexadecimal numbers ------------------------------------------------------------------------ r2274 | Darkvater | 2005-05-06 16:13:44 +0000 (Fri, 06 May 2005) | 1 line - Codechange: some comments, parentheses and EngineID typedef for engine_type ------------------------------------------------------------------------ r2273 | celestar | 2005-05-06 12:00:25 +0000 (Fri, 06 May 2005) | 1 line -Fix: Road vehicles no longer try to obtain a slot when they have crashed. (peter1138) ------------------------------------------------------------------------ r2272 | tron | 2005-05-06 06:59:24 +0000 (Fri, 06 May 2005) | 1 line Remove unused attribute from struct Station ------------------------------------------------------------------------ r2271 | tron | 2005-05-06 06:56:30 +0000 (Fri, 06 May 2005) | 2 lines CMD_SET_PLAYER_FACE, CMD_SET_PLAYER_COLOR, CMD_INCREASE_LOAN, CMD_DECREASE_LOAN only make sense for the current player, so don't explicitly pass a player number ------------------------------------------------------------------------ r2270 | Darkvater | 2005-05-05 20:46:14 +0000 (Thu, 05 May 2005) | 1 line - Fix/Codechange: fix up selling rail vehicles. Try to be smart about it. When selling dual-headed trains, also sell the rear end; if the now-first wagon is an engine, make it a train. When selling the whole train, try to leave dual-headed setups intact ------------------------------------------------------------------------ r2269 | Darkvater | 2005-05-05 20:44:52 +0000 (Thu, 05 May 2005) | 1 line - CodeChange: no else after return; exchange some magic 0xffff with INVALID_VEHICLE, vehicle index is of type VehicleID ------------------------------------------------------------------------